Skip to content

Conversation

@rarDevelopment
Copy link
Contributor

The URL has changed once again!

@xavdid
Copy link

xavdid commented Dec 28, 2024

I think this will work but it may be worth assuming the url will change again in the future (or swap every day or something) and accommodate that. I'd be surprised if this is the last change like this we see!

@rarDevelopment
Copy link
Contributor Author

I think this will work but it may be worth assuming the url will change again in the future (or swap every day or something) and accommodate that. I'd be surprised if this is the last change like this we see!

Agreed. Unfortunately, the nature of the changes sometimes varies beyond just the URL change, so there are a lot of ways it could still break in the future. Either way, accommodating the URL makes sense, I'll leave that to @ScrappyCocco here as I've got my own spots to make such accommodations 🥲

@ScrappyCocco ScrappyCocco self-assigned this Dec 29, 2024
Copy link
Owner

@ScrappyCocco ScrappyCocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed, review ok

@ScrappyCocco ScrappyCocco merged commit a746c98 into ScrappyCocco:master Dec 29, 2024
4 checks passed
@ScrappyCocco
Copy link
Owner

@xavdid what's your idea, keep a list of possible url to try? You can open an issue to discuss that

morwy added a commit to morwy/hltb-for-deck that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants